feat(workshopper): resolve generation timeouts and improve timetable#16
Merged
Conversation
…editing - **Backend Concurrency:** Refactored `WorkshopService.java` to use a dedicated class-level `ExecutorService` for blocking LLM network calls, preventing `ForkJoinPool` thread starvation and deadlocks during concurrent session block generation. - **Draft Persistence:** Fixed a race condition in `App.tsx` where pending LLM block generation promises were not properly resolved when saving a draft, causing the UI to become permanently stuck in a loading state. - **LGH Integration:** Removed the strict `?status=APPROVED` filter from the Learning Goal Hub fetch to allow importing all available goals, and added graceful error boundary toasts for when the LGH service is offline. - **Timetable UI:** Enhanced the `SortableBlockRow` to allow activity text editing even when not in full edit mode. Added a helpful info tooltip to the activity prompt.
florivn
approved these changes
Jul 17, 2026
florivn
left a comment
florivn
left a comment
Contributor
There was a problem hiding this comment.
Review by gpt-5.6 Luna:
PR #16 improves Workshopper’s reliability and timetable UX:
- Uses bounded concurrent LLM calls to reduce generation timeouts.
- Improves draft persistence and proxy timeouts.
- Adds more flexible Learning Goal Hub imports.
- Adds explicit timetable edit mode and concurrent slide generation.
What’s good: the concurrency limit, per-block generation, and clearer edit/save workflow are solid improvements.
Changes needed before approval:
- Preserve result.id if the initial draft save fails; otherwise the generated session ID is lost and finalization becomes impossible.
- Isolate pending draft-save resolvers; overlapping saves can resolve with the wrong ID or before the latest draft is persisted.
- Add regression tests for both draft-save failure and overlapping saves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkshopService.javato use a dedicated class-levelExecutorServicefor blocking LLM network calls, preventingForkJoinPoolthread starvation and deadlocks during concurrent session block generation.App.tsxwhere pending LLM block generation promises were not properly resolved when saving a draft, causing the UI to become permanently stuck in a loading state.?status=APPROVEDfilter from the Learning Goal Hub fetch to allow importing all available goals, and added graceful error boundary toasts for when the LGH service is offline.SortableBlockRowto allow activity text editing even when not in full edit mode. Added a helpful info tooltip to the activity prompt.